fix: don't cleanup topics on engine close (#4658) #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
force-pushed
the
backport-query-fix-5.1.x
branch
5 times, most recently
from
3db5df8
to
6eb85a7
Compare
Co-authored-by: Rohan <[email protected]> Co-authored-by: Andy Coates <[email protected]>
stevenpyzhang
force-pushed
the
backport-query-fix-5.1.x
branch
from
6eb85a7
to
3922fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like https://github.com/confluentinc/ksql/pull/4819/files but for 5.1
Backports these fixes
#4643
#4658
I don't think it's possible to backport the KsqlEngineTest since 5.1.x is when it was still using EasyMock, so there's no
Spyoption for thetopicClient.Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist