fix: allow trailing slash in listeners config (MINOR) #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
approved these changes
Apr 7, 2020
Comment on lines
55
to
56
| // the getHost/getPort utilities don't handle URLs that end with `/` - since this issue | ||
| // has come up multiple times for ksqlDB we special case it here |
There was a problem hiding this comment.
I don't think the comment adds anything to the code.
How about removing and maybe reference the issue in the test?
There was a problem hiding this comment.
fair enough - i just removed it altogether, if someone is interested they can see commit history
vpapavas
pushed a commit
to vpapavas/ksql
that referenced
this pull request
Apr 15, 2020
vpapavas
pushed a commit
to vpapavas/ksql
that referenced
this pull request
Apr 15, 2020
vpapavas
added a commit
that referenced
this pull request
Apr 15, 2020
Authored-by: Almog Gavra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4668
Description
See the description in the issue, we should allow listener IPs with trailing slash (e.g.
http://localhost:8080/)Testing done
Unit testing
Reviewer checklist