Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace 'null' in explain plan with correct op type (MINOR) #5075

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

StreamGroupByKey steps resulted in a null op type, but now resolve correctly to GROUP_BY. In the future, unsupported types will result in an exception.

Testing done

usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

 `StreamGroupByKey` steps resulted in a `null` op type, but now resolve correctly to `GROUP_BY`. In the future, unsupported types will result in an exception.
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@big-andy-coates big-andy-coates merged commit f9bc0e6 into confluentinc:master Apr 16, 2020
@big-andy-coates big-andy-coates deleted the plan_summary branch April 16, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants