don't execute dropped streams/tables, but update metastore #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurvam
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
LGTM!
For my understanding, terminated queries would always behave correctly in this regard: they would be added to the metadata but not started.
Your patch basically also adds additional state to indicate that a statement has been eventually dropped. And then you give these eventually dropped statements the same treatment as the terminated queries, causing the behavior to be consistent. Correct?
|
@apurvam, yes that is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During startup when reading and executing the prior commands we need to update the metastore for tables/streams that are subsequently dropped so that dependent commands can also execute, i.e. if we have
create stream s1 as select ...
create stream s2 as select * from s1
terminate query 'csas_s1'
drop s1
when we restart we should still have s2 running
#531