Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip on configuring artifactory to ensure builds are working #538

Merged
merged 2 commits into from
Dec 19, 2017

Conversation

miguno
Copy link
Contributor

@miguno miguno commented Dec 18, 2017

No description provided.

@miguno
Copy link
Contributor Author

miguno commented Dec 18, 2017

Several community members have run into build issues, at least some of which could be traced back to these users having Maven proxy/mirror issues (= not an issue on our side).

Copy link
Contributor

@joel-hamill joel-hamill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested grammar fixes

@@ -57,6 +57,10 @@ connect is [UP]
$ mvn clean compile install -DskipTests
```

> Tip: When using a Maven proxy/mirror in your company such as Artifactory you must make sure that it is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd revise to: Tip: When using a Maven proxy or mirror, such as Artifactory, make sure that it is correctly configured to retrieve snapshot artifacts and access snapshot repositories. For more information, see [Could not find artifact](https://github.com/confluentinc/ksql/issues/537).

@miguno miguno changed the base branch from 4.0.x to master December 19, 2017 08:07
@miguno
Copy link
Contributor Author

miguno commented Dec 19, 2017

I changed this PR to target master (before: 4.0.x).

@miguno miguno merged commit c00d117 into master Dec 19, 2017
@miguno miguno deleted the 4.0.x-artifactory branch December 21, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants