feat: Pull Queries: QPS check utilizes internal API flag to determine if forwarded #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanConfluent
changed the title
AlanConfluent
changed the title
AlanConfluent
changed the title
vpapavas
reviewed
May 18, 2020
| // treat it as having been forwarded. | ||
| final boolean isAlreadyForwarded = routingOptions.skipForwardRequest() && | ||
| // Trust the forward request option if isInternalRequest isn't available. | ||
| isInternalRequest.orElse(true); |
There was a problem hiding this comment.
In which scenarios would isInternalRequest not be available? Don't we want these two variables (skipForwardRequest and isInternalRequest) to always either both be true or both be false? Which makes me question whether we need both.
There was a problem hiding this comment.
isInternalRequest wouldn't be available when the internal listener functionality is not enabled, so we still would want skipForwardRequest in that case where it's running in a trusted setting and still wants to know to only forward the request once. But yes, you're right that they aim to infer the identical thing -- that this request is forwarded rather than from the end user.
AlanConfluent
changed the title
AlanConfluent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing pull queries, we do a QPS check. At the moment, we only check at the initial client request, regardless of whether it gets forwarded. This makes it easy to reason about the total cluster QPS.
To do this, we utilize a request property,
request.ksql.query.pull.skip.forwarding. This PR adds the additional requirement that ifksql.internal.listeneris in use, the request must be internal to be considered a forwarded request.This prevents a user from setting
request.ksql.query.pull.skip.forwardingexplicitly.Testing done
mvn package. Also tested manually.Reviewer checklist