feat: new UDFs for array max/min/sort #5505
Conversation
|
|
||
| @Udf | ||
| public <T extends Comparable<? super T>> T arrayMax(@UdfParameter( | ||
| description = "The array to sort") final List<T> input) { |
There was a problem hiding this comment.
I'm guessing this isn't the intended description.
There was a problem hiding this comment.
good catch, thx!
|
|
||
| @Udf | ||
| public <T extends Comparable<? super T>> T arrayMin(@UdfParameter( | ||
| description = "The array to sort") final List<T> input) { |
There was a problem hiding this comment.
I'm guessing this isn't the intended description.
| ### ``ARRAY_SORT`` | ||
|
|
||
| ```sql | ||
| ARRAY_SORT(["foo", "bar", "baz"]) |
There was a problem hiding this comment.
I know this array literal isn't intended to be a valid argument, but it may be worth using single quotes here since ARRAY["foo", "bar"] wouldn't parse.
There was a problem hiding this comment.
fixed all the occurrences i could find
| ARRAY_SORT(["foo", "bar", "baz"]) | ||
| ``` | ||
|
|
||
| Given an array of primitive elements (not arrays of other arrays, or maps, or structs, or combinations thereof), returns an array of the same elements sorted according to their natural sort order. Any NULLs contained in the array will always be moved to the end. |
There was a problem hiding this comment.
I think it would be worth adding a note and example or two about the optional ASC or DESC order specifier since that's pretty useful.
There was a problem hiding this comment.
yep, oversight on my part. adding now
There was a problem hiding this comment.
Thank you @blueedgenick! Awesome job!
I forgot to say, before you merge, you need to add the subfoler created in ksql/ksqldb-functional-tests/src/test/resources/historical_plans for your QTT test. There should be three files, the spec.json, the plan.json and the topology. If you need to create them manually, you can run PlannedTestGeneratorTest.manuallyGeneratePlans which will generate plans for all QTT tests .
Description
Three new UDFs for array manipulation:
Docs updated.
Testing done
Accompanying unit and QTT tests added.