Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry on connection closed #5515

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

purplefox
Copy link
Contributor

Description

Fixes a bug where execution of a query from the console can cause a connection closed exception if executed very quickly after a previous query was terminated.

This is extremely unlikely to happen in real usage, but does happen intermittently in the test suite.

Testing done

Fixes test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner May 30, 2020 09:25
@purplefox purplefox requested a review from vpapavas May 30, 2020 09:26
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purplefox purplefox merged commit 8eb1f88 into confluentinc:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants