feat: support TIMESTAMP being a key column #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#5538 The `TIMESTAMP` property that can be specified in the `WITH` clause can now reference key columns. Fixes confusing error message if the user does reference a key column as their Timestamp column: ```sql CREATE TABLE FOO (K BIGINT PRIMARY KEY, NAME STRING) WITH (TIMESTAMP='K', ...); -- error: The TIMESTAMP column set in the WITH clause does not exist in the schema: K ``` When clearly `K` is part of the schema!
agavra
approved these changes
Jun 3, 2020
ksqldb-functional-tests/src/test/resources/query-validation-tests/timestamp-extractor.json
Show resolved
Hide resolved
...s/src/main/java/io/confluent/ksql/execution/streams/timestamp/LoggingTimestampExtractor.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/io/confluent/ksql/execution/streams/timestamp/TimestampColumnExtractors.java
Show resolved
Hide resolved
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Jun 5, 2020
* feat: support TIMESTAMP being a key column fixes: confluentinc#5538 The `TIMESTAMP` property that can be specified in the `WITH` clause can now reference key columns. Fixes confusing error message if the user does reference a key column as their Timestamp column: ```sql CREATE TABLE FOO (K BIGINT PRIMARY KEY, NAME STRING) WITH (TIMESTAMP='K', ...); -- error: The TIMESTAMP column set in the WITH clause does not exist in the schema: K ``` When clearly `K` is part of the schema! Co-authored-by: Andy Coates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #5538
The
TIMESTAMPproperty that can be specified in theWITHclause can now reference key columns.Fixes confusing error message if the user does reference a key column as their Timestamp column:
When clearly
Kis part of the schema!Testing done
usual
Reviewer checklist