Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new string UDFs LPad, RPad #5546

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

blueedgenick
Copy link
Contributor

Simple string-padding functions based on the RDBMS stalwarts of the same names.

  • LPad(input_str, target_len, padding_str)
  • RPad(input_str, target_len, padding_str)

Docs, unit tests, QTT, historical plans for the above.

@blueedgenick blueedgenick requested review from JimGalasyn and a team as code owners June 3, 2020 20:41
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few suggestions.

@vpapavas vpapavas self-assigned this Jun 3, 2020
Copy link
Member

@vpapavas vpapavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @blueedgenick ! LGTM

@blueedgenick blueedgenick merged commit 00f5083 into confluentinc:master Jun 3, 2020
@blueedgenick blueedgenick deleted the lpad_rpad_udfs branch June 11, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants