Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow requests to /inserts-stream if insert values disabled #5592

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jun 10, 2020

Description

Fixes #5590. This will also need to be backported to 5.5.x.

Testing done

Not sure what makes sense in terms of automated testing. Endpoint-specific code currently can only be tested with integration tests, not unit tests. Because this functionality requires different server configs, we'd have to add a separate integration test file just for this, which feels really heavy-weight. @purplefox do you have recommendations?

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner June 10, 2020 07:58
@vcrfxia vcrfxia requested a review from purplefox June 10, 2020 08:00
@vcrfxia
Copy link
Contributor Author

vcrfxia commented Jun 10, 2020

Turns out this doesn't need to be backported to 5.5.x since the /inserts-stream functionality wasn't implemented on 5.5.x:

@vcrfxia vcrfxia merged commit e277f25 into confluentinc:6.0.x Jun 10, 2020
@vcrfxia vcrfxia deleted the inserts-stream-config-60x branch June 10, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants