fix: do not overwrite schemas from a CREATE STREAM/TABLE #5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks almog. Do we know when the regression was introduced? Ie. which version of community ksqlDB? |
vpapavas
reviewed
Jul 1, 2020
| @@ -96,7 +99,8 @@ private void registerForCreateAs(final ConfiguredStatement<? extends CreateAsSel | |||
| queryMetadata.getResultTopic().getKafkaTopicName(), | |||
| queryMetadata.getResultTopic().getValueFormat().getFormatInfo(), | |||
| cas.getConfig(), | |||
| cas.getStatementText() | |||
| cas.getStatementText(), | |||
| true | |||
There was a problem hiding this comment.
Just to make sure, in which case to we want to overwrite existing schemas?
There was a problem hiding this comment.
we want to overwrite existing schemas in the case of CREATE * AS SELECT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #5553
This commit makes sure that
C*statements do not overwrite existing schemas in schema registry and instead only check compatibility with a declared schema, if a declared schema is present.NOTE: if you
INSERT INTOa stream, all bets are off (i.e. another schema will be registered under the schema value, but that is not a regression as this is a serializer-specific behavior)Testing done
Unit tests, and manual testing (registered the same source with a subset schema and confirmed there's only one version in schema registry)
Reviewer checklist