fix: always use the changelog subject in table state stores #5823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5673
replaces #5812
Description
This commit takes a different approach to fixing the issue described in the two links above; we will hardcode the serializer for source tables to use the changelog topic, and we allow the deserializer to fallback to the source topic if it fails to deserialize using the changelog topic.
This fixes the issue by obviating apache/kafka#8902 - all queries that were created before #5781 was merged will always pass in the changelog topic to their state store serde. This means that:
INSERT INTO
Review Guide
SourceBuilder
, where we pass into theConsumed
instance a custom Serde that spoofs the topic to always use the changelog topicStaticTopicSerde
RegisterSchemaCallback
to help optimize repeated failed deserialization attemptsLoggingDeserializer
is extended to support delaying the exceptional caseTesting done
Reviewer checklist