Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSQL-508: add metrics interceptors instead of replacing #585

Merged
merged 7 commits into from
Jan 9, 2018
Merged

Commits on Jan 4, 2018

  1. KSQL-508: add metrics interceptors instead of replacing

    Have the physical plan builder add metrics interceptors instead of
    replacing the existing ones. It looks at the current setting, and
    builds a list of interceptor classes/names out of it. Finally, the
    builder appends the metrics collector interceptor to the list.
    
    To test these changes I added an accessor for the underlying stream
    config to QueryMetadata. The tests pull the configured interceptors
    from the stream config and verify that they include both the client
    and the metrics interceptors.
    rodesai committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    4fbe023 View commit details
    Browse the repository at this point in the history
  2. Fix indentation

    rodesai committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    7e96cd8 View commit details
    Browse the repository at this point in the history
  3. Unneccessary imports

    rodesai committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    5281547 View commit details
    Browse the repository at this point in the history
  4. Address review comments

    - Dont pass the stream configs around just for the sake of testing.
      Instead, factor out the last step of KafkaStreams construction into
      a factory interface that we can fake out in the test to intercept
      the args, which includes the streams config
    - Split the client interceptor config before turning it into a list
    rodesai committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    99306fa View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Configuration menu
    Copy the full SHA
    f997de1 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Configuration menu
    Copy the full SHA
    1b42daa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3aabf3 View commit details
    Browse the repository at this point in the history