Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make null rows follow schema #6086

Closed
wants to merge 1 commit into from

Conversation

jzaralim
Copy link
Contributor

Description

Currently, null row values are just stored as nulls. These rows get excluded from a lot of queries from not having proper columns. This PR updates the deserializer so that it would return rows with null fields instead of just nulls.

This would fix #5633 and #5634 . However, I'm not sure if there are any side effects.

Testing done

Added QTT tests. A lot of unit tests fail - I will update these if we decide that this is actually something we want to do.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim
Copy link
Contributor Author

@big-andy-coates @spena Here's what a fix for the null row problem would look like. It's not a huge change, but I'd like to know if there is anything else that should be considered.

@spena spena requested a review from a team August 25, 2020 17:03
Copy link

cla-assistant bot commented Nov 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zara Lim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vvcephei
Copy link
Member

Closing stale PR. I'm sorry that we didn't get this done. Please resubmit as a new PR if you still want to get it in.

@vvcephei vvcephei closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream GROUP BY excludes null values.
2 participants