Add ksql-tools #634
Merged
Add ksql-tools #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a module for ksql command line tools. Include a tool for printing ksql metrics exposed as mbeans.
satybald
reviewed
Jan 16, 2018
| Map<Integer, LocalVirtualMachine> jvms = LocalVirtualMachine.getAllVirtualMachines(); | ||
| LocalVirtualMachine jvm = null; | ||
| if (pid == -1) { | ||
| for (LocalVirtualMachine j : jvms.values()) { |
There was a problem hiding this comment.
I'd propose to use the different variable name here. i, js commonly used for index variables.
satybald
reviewed
Jan 16, 2018
| + "pid=<KSQL PID>"); | ||
| } | ||
|
|
||
| public static class PrintMetricsException extends RuntimeException { |
There was a problem hiding this comment.
what do you think about having PrintMetricsException and ArgumentMetricsException in separate exception package?
|
Would you like to add a shell script in |
bluemonk3y
approved these changes
Jan 17, 2018
| } catch (Exception error) { | ||
| throw new PrintMetricsException("Unexpected error getting attribute " + error.getMessage()); | ||
| } | ||
| System.out.println(attributeInfo.getName() + ": " + attribute); |
There was a problem hiding this comment.
at some point we might want to provide a formatter so data could displayed as CSV, JSON, statsd or delimited - the output could then be sent to a remote REST EP
There was a problem hiding this comment.
Missed this. I'll file an issue so we don't lose track of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a module for ksql command line tools. Include a tool for
printing ksql metrics exposed as mbeans.