Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for DELIMITED key format #6344

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #6227

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easy! AVRO and JSON_SR will be done by tomorrow, right? ;D

@@ -47,7 +47,7 @@ currently supported as key formats. See individual formats for details.
| Feature | Supported |
|------------------------------|-----------|
| As value format | Yes |
| As key format | No |
| As key format | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@big-andy-coates big-andy-coates merged commit 04af65c into confluentinc:master Oct 2, 2020
@big-andy-coates big-andy-coates deleted the delimited_keys branch October 2, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DELIMITED Support]: Support DELIMITED as a key format
3 participants