fix: recovery hangs when using TERMINATE ALL #6397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #6390
this PR now properly handles
TERMINATE ALL
. I checked to see if I could do this without "hacking" the fact that theQueryId
isALL
but it would require parsing the statement, which would require quite a few changes (like passing the engine into the compactor, which doesn't sound right). Anything else (changing theCommandId
) is not backwards compatible.Testing done
Unit test
Reviewer checklist