Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable support for JSON key format #6411

Merged
merged 3 commits into from
Oct 13, 2020
Merged

feat: enable support for JSON key format #6411

merged 3 commits into from
Oct 13, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #4461

Testing done

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner October 13, 2020 13:49
agavra
agavra approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@big-andy-coates big-andy-coates merged commit fe97cde into confluentinc:master Oct 13, 2020
@big-andy-coates big-andy-coates deleted the json_keys branch October 13, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Json primitive keys
2 participants
@big-andy-coates @agavra