Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suppression of method length check #662

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Remove suppression of method length check #662

merged 1 commit into from
Jan 26, 2018

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Jan 26, 2018

No description provided.

apurvam
apurvam approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@dguy dguy mentioned this pull request Jan 26, 2018
Closed
@dguy
Copy link
Contributor Author

dguy commented Jan 26, 2018

@hjafarpour @rodesai

hjafarpour
hjafarpour approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dguy dguy merged commit d8693d9 into confluentinc:master Jan 26, 2018
@dguy dguy deleted the method-length-check branch January 26, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurvam apurvam apurvam approved these changes

@hjafarpour hjafarpour hjafarpour approved these changes

@rodesai rodesai Awaiting requested review from rodesai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dguy @apurvam @hjafarpour