Cos integration for KSQL. #663
Conversation
debian/confluent-kafka-rest.postinst
Outdated
|
|
||
| if [ -n "$_permwarn" ]; then | ||
| echo "Notice: If you are planning to use the provided systemd service units for" | ||
| echo "Notice: confluent-schema-registry, make sure that read-write permissions" |
debian/confluent-kafka-rest.service
Outdated
| [Unit] | ||
| Description=Streaming SQL engine for Apache Kafka | ||
| Documentation=http://docs.confluent.io/ | ||
| After=network.target confluent-kafka.target |
There was a problem hiding this comment.
add confluent-schema-registry.target as well and any other deps you have
This is not forcing them to start but defines the startup order if those services are enabled locally.
debian/confluent-kafka-rest.service
Outdated
| User=cp-ksql | ||
| Group=confluent | ||
| Environment="LOG_DIR=/var/log/confluent/ksql" | ||
| ExecStart=/usr/bin/kafka-ksql-start /etc/kafka-ksql/kafka-ksql.properties |
There was a problem hiding this comment.
I think /etc/kafka-ksql needs to match PACKAGE_TITLE, so /etc/ksql
debian/confluent-kafka-rest.spec.in
Outdated
|
|
||
| if [ -n "$_permwarn" ]; then | ||
| echo "Notice: If you are planning to use the provided systemd service units for" | ||
| echo "Notice: confluent-schema-registry, make sure that read-write permissions" |
debian/confluent-kafka-rest.spec.in
Outdated
| %{__mkdir_p} %{buildroot} | ||
| %{__cp} -R * %{buildroot} | ||
| # The spec file gets included, get rid of it | ||
| %{__rm} %{buildroot}/confluent-kafka-rest.spec |
debian/confluent-kafka-rest.spec.in
Outdated
| %doc | ||
| /usr/share/doc/kafka-ksql | ||
|
|
||
| %config(noreplace) /etc/kafka-ksql/* |
debian/confluent-kafka-rest.spec.in
Outdated
| [ "%{buildroot}" != "/" ] && %{__rm} -rf %{buildroot} | ||
|
|
||
| %changelog | ||
| * Fri Jan 2 2015 Confluent Packaging <[email protected]> |
|
@edenhill applied your feedback. Please let me know if you find any other issues. |
| find bin/ -type f | grep -v README[.]rpm | xargs -I XXX $(INSTALL_X) -o root -g root XXX $(DESTDIR)$(PREFIX)/XXX ;\ | ||
| find share/ -type f | grep -v README[.]rpm | xargs -I XXX $(INSTALL) -o root -g root XXX $(DESTDIR)$(PREFIX)/XXX ; \ | ||
| pushd etc/ksql/ ; \ | ||
| find . -type f | grep -v README[.]rpm | xargs -I XXX $(INSTALL) -o root -g root XXX $(DESTDIR)$(SYSCONFDIR)/XXX |
There was a problem hiding this comment.
hint:
To (manually) verify final package contents, do:
for archive:
tar tvzf output/..ksql..tar.gz
rpm:
rpm -qpl output/..ksql..rpm
deb:
dpkg -c output/..ksql..all.deb
|
Don't forget to add the systemd .service file |
|
It still seems to be missing the confluent-ksql.service file |
|
@edenhill yes, just added the missing files. |
debian/confluent-ksql.service
Outdated
| User=cp-ksql | ||
| Group=confluent | ||
| Environment="LOG_DIR=/var/log/confluent/ksql" | ||
| ExecStart=/usr/bin/ksql-start /etc/ksql/ksql.properties |
There was a problem hiding this comment.
seems the filename is supposed to be ksqlserver.properties?
| Type=simple | ||
| User=cp-ksql | ||
| Group=confluent | ||
| Environment="LOG_DIR=/var/log/confluent/ksql" |
There was a problem hiding this comment.
ksql-run-class (or wahtever it is called) needs to be updated to set the ksql.log.dir property based on LOG_DIR, and then change the config/log4j...properties to use ksql.log.dir rather than the hardcoded /tmp/ksql..
There was a problem hiding this comment.
Looks good but the run-class file must be updated to set ksql.log.dir based on LOG_DIR.
See this for an example:
https://github.com/confluentinc/kafka-rest/blob/master/bin/kafka-rest-run-class#L42
bin/ksql-run-class
Outdated
| @@ -8,17 +8,11 @@ set -ue | |||
| #cd -P deals with symlink from /bin to /usr/bin | |||
| base_dir=$( cd -P "$( dirname "${BASH_SOURCE[0]}" )/.." && pwd ) | |||
|
|
|||
| # Log directory to use | |||
There was a problem hiding this comment.
I think you should keep this, for providing a defualt log dir (/tmp/..) when LOG_DIR env has not been set.
This also makes sure ksql.log.dir is always set, otherwise the log4j properties will be ran out of the root / dir which will not work.
No description provided.