Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add partitions to PRINT TOPIC output #6641

Merged
merged 2 commits into from
Nov 23, 2020
Merged

feat: add partitions to PRINT TOPIC output #6641

merged 2 commits into from
Nov 23, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Nov 18, 2020 •
edited
Loading

Description

Simple change to add partitions to the output of print topic

Testing done

Unit testing & local testing

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra marked this pull request as ready for review November 19, 2020 22:40
@agavra agavra requested a review from a team as a code owner November 19, 2020 22:40
vcrfxia
vcrfxia approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agavra agavra merged commit 1f4eff8 into confluentinc:master Nov 23, 2020
@agavra agavra deleted the print_partition branch November 23, 2020 21:01
@agavra agavra mentioned this pull request May 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agavra @vcrfxia