Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for windowed SR-key joins #6661

Merged
merged 4 commits into from
Nov 24, 2020
Merged

chore: add support for windowed SR-key joins #6661

merged 4 commits into from
Nov 24, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Nov 23, 2020

Description

Follows up from #6642 to actually enable support for windowed joins for SR-keys. This also fixes an issue where forced repartition allowed arbitrary repartitioning of tables.

Testing done

QTT

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from vcrfxia November 23, 2020 21:10
@agavra agavra requested a review from a team as a code owner November 23, 2020 21:10
vcrfxia
vcrfxia approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @agavra ! Great catch on the bug.

@agavra agavra merged commit a54c114 into confluentinc:master Nov 24, 2020
@agavra agavra deleted the window_joins branch November 24, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agavra @vcrfxia