fix: (minor) don't use deprecated jersey calls #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @niteshmor just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Jersey 2.30 (and above) adds a Configuration argument to `ContainerRequest(...)` and marks the old version of `ContainerRequest(...)` without the Configuration argument as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the call signature for jersey's
ContainerRequest(...)to a non-deprecated one in a test. Jersey 2.30 and above add a newConfigurationparameter (see here).The context for this pull request is that I am trying to update Jersey to 2.31 in upstream rest-utils (confluentinc/rest-utils#210). Ksql treats warnings as errors, and the deprecation warning causes the upstream pull request from building correctly. Once that pull request actually upgrades the jetty version, ksql builds would fail without this current PR specifically because of treating deprecation warnings as errors.
Merging this pull request will cause the immediate builds to break, but the current ksql build is already broken as of now. The reason for the current broken build is multiple jetty versions, which the upstream PR attempts to fix.
Testing done
None
Reviewer checklist