fix: include 'ksql.streams.topic.*' prefix properties on LIST PROPERTIES output #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
force-pushed
the
fix_topic_props_on_list
branch
from
b5c772c
to
770ffa2
Compare
agavra
approved these changes
Dec 9, 2020
| private static Set<String> streamTopicConfigNames() { | ||
| final ImmutableSet.Builder<String> configs = ImmutableSet.builder(); | ||
|
|
||
| Arrays.stream(TopicConfig.class.getDeclaredFields()) |
There was a problem hiding this comment.
heh.. this is a neat trick. I guess there's no other option to get these configs without reflection and just manually adding them?
There was a problem hiding this comment.
Right. I was thinking of manually creating the list, but TopicConfig can change in the future, and we'll have to adjust every time it changes. I'm not a fan of reflection, but I like the magic on it. This magic helps to forget about changes in TopicConfig as long as they stay public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6734
Includes
ksql.streams.topic.*prefixed properties into theLIST PROPERTIESoutput.It also allows users to set the
ksql.streams.topic.*properties from the CLI.Testing done
Added unit tests
Verified manually
Reviewer checklist