feat: ungate support for multi-column GROUP BY #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
force-pushed
the
unflag-group-by-multi
branch
5 times, most recently
from
71124cb
to
071f271
Compare
vcrfxia
force-pushed
the
unflag-group-by-multi
branch
from
071f271
to
1bc2582
Compare
agavra
approved these changes
Dec 17, 2020
|
Pull query support (for equality conditions) is added in #6796, and will also be merged in time for 0.15. Merging now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes support for multi-column GROUP BY from behind the feature flag, and also adds docs. If we merge this PR now, we can catch 0.15. Ideally we'd wait until pull query support for multiple key columns has been added, though.
BREAKING CHANGE: Queries with
GROUP BYclauses that contain multiple grouping expressions now result in multiple key columns, one for each grouping expression, rather than a single key column that is the string-concatenation of the grouping expressions. Note that this new behavior (and breaking change) apply only to new queries; existing queries will continue to run uninterrupted with the previous behavior, even across ksqlDB server upgrades.Three commits:
Testing done
QTT.
Reviewer checklist