Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add standard deviation udf #6845

Merged
merged 6 commits into from
Jan 13, 2021
Merged

feat: add standard deviation udf #6845

merged 6 commits into from
Jan 13, 2021

Conversation

lct45
Copy link
Contributor

@lct45 lct45 commented Jan 8, 2021

Description

Add a standard deviation UDF, per #6716. This implementation uses the sample standard deviation calculation, later extensions can add support for population standard deviation.

Testing done

Unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@lct45 lct45 requested review from JimGalasyn and a team as code owners January 8, 2021 20:50
@ghost
Copy link

ghost commented Jan 8, 2021

@confluentinc It looks like @lct45 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

agavra
agavra reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed this quickly (I'll look into the code itself sometime soon) - don't forget to add corresponding qtt tests 😄 See sum.json for an example

@agavra agavra requested a review from a team January 8, 2021 21:52
JimGalasyn
JimGalasyn approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggestion.

spena
spena approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the changes. LGTM

@lct45 lct45 merged commit f2fdbb3 into confluentinc:master Jan 13, 2021
@JimGalasyn JimGalasyn mentioned this pull request Mar 16, 2021
Merged
@lct45 lct45 deleted the st_dev branch July 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra left review comments

@blueedgenick blueedgenick blueedgenick left review comments

@spena spena spena approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lct45 @agavra @blueedgenick @spena @JimGalasyn