Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Select * avoid code gen for projections #6846

Merged

Conversation

AlanConfluent
Copy link
Member

@AlanConfluent AlanConfluent commented Jan 8, 2021

Description

Prior to #6684, select * didn't compile expressions for each of the columns, which makes them much more performant. This PR remakes that change to avoid a regression.

Testing done

Unit tests and local benchmarking

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@AlanConfluent AlanConfluent requested a review from a team as a code owner January 8, 2021 21:41
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the quick fix on this one. For anyone following along, we'll need to figure out something long-term to make all pull queries (not just select * queries) efficient (or set expectations around what the expected performance of queries are).

@AlanConfluent AlanConfluent merged commit 0896b85 into confluentinc:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants