Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for incompatible command detection with backups enabled #6870

Conversation

stevenpyzhang
Copy link
Member

Description

There's a bug in 0.14.0 that causes the server to not enter degraded state when backups are enabled.
The bug is fixed in #6524 (removing deserialization from the CommandTopicBackupImpl)

This adds an integration test to check that incompatible commands are properly processed.
Also, enhanced the corruption integration test and cleaned up some other tests.

Testing done

test only change

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team as a code owner January 15, 2021 02:50
@stevenpyzhang stevenpyzhang force-pushed the integration-test-incompatible-command branch from d7b22ed to 9f4d003 Compare January 15, 2021 04:01
@stevenpyzhang stevenpyzhang force-pushed the integration-test-incompatible-command branch from 9f4d003 to fa4a243 Compare January 16, 2021 05:06
@stevenpyzhang stevenpyzhang requested review from spena and a team January 20, 2021 06:04
@stevenpyzhang stevenpyzhang force-pushed the integration-test-incompatible-command branch from 163dc8a to 54de09c Compare January 21, 2021 18:54
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevenpyzhang stevenpyzhang merged commit 645e042 into confluentinc:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants