feat: Adds ability to bypass cache for pull queries #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @cprasad1 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
.../java/io/confluent/ksql/execution/streams/materialization/ks/KsMaterializedSessionTable.java
Outdated
Show resolved
Hide resolved
...n/java/io/confluent/ksql/execution/streams/materialization/ks/KsMaterializedWindowTable.java
Show resolved
Hide resolved
...main/java/io/confluent/ksql/execution/streams/materialization/ks/WindowStoreCacheBypass.java
Show resolved
Hide resolved
| Objects.requireNonNull(keyTo, "upper key can't be null"); | ||
| final List<ReadOnlyWindowStore<GenericKey, ValueAndTimestamp<GenericRow>>> stores | ||
| = getStores(store); | ||
| for (final ReadOnlyWindowStore<GenericKey, ValueAndTimestamp<GenericRow>> windowStore :stores) { |
There was a problem hiding this comment.
You can probably put this for loop in a method that takes a lambda:
findFirstNonEmptyIterator(... stores, Function<ReadOnlyWindowStore<GenericKey, ValueAndTimestamp<GenericRow>>, KeyValueIterator<Windowed<GenericKey>> func) {
for (...) {
}
}
You might have to make a generic parameter of the method if you want to handle the WindowStoreIterator as well, but it could simplify the code a bit more.
There was a problem hiding this comment.
I have tried to implement that, but it required a bit of type casting and I am nervous about that
...ain/java/io/confluent/ksql/execution/streams/materialization/ks/SessionStoreCacheBypass.java
Outdated
Show resolved
Hide resolved
...ain/java/io/confluent/ksql/execution/streams/materialization/ks/SessionStoreCacheBypass.java
Outdated
Show resolved
Hide resolved
...ain/java/io/confluent/ksql/execution/streams/materialization/ks/SessionStoreCacheBypass.java
Outdated
Show resolved
Hide resolved
vvcephei
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Thanks, @cprasad1 !
Overall, this PR LGTM. Once you've addressed @AlanConfluent 's feedback, I'm ok to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to bypass cache for pull queries
Testing done
Updated existing unit tests
Reviewer checklist