Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select star table scans need keys in the intermediate row #6908

Merged

Conversation

AlanConfluent
Copy link
Member

Description

The intermediate row in a projection currently only contains a key if the PullFilterNode requires it, which means that select * only works on key lookups. With this change, we make sure to add keys if it's a select * so that it's now found for table scan.

Testing done

RQTT tests and unit tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@AlanConfluent AlanConfluent requested a review from a team as a code owner January 28, 2021 01:36
@AlanConfluent AlanConfluent merged commit fcac459 into confluentinc:master Jan 28, 2021
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants