Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npe when getting topic configs #6946

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: npe when getting topic configs #6946

merged 1 commit into from
Feb 4, 2021

Conversation

stevenpyzhang
Copy link
Member

Description

Fixes #6885

Testing done

Updated unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team as a code owner February 3, 2021 22:41
wcarlson5
wcarlson5 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@wcarlson5 wcarlson5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenpyzhang stevenpyzhang merged commit 5e026d4 into confluentinc:master Feb 4, 2021
stevenpyzhang added a commit to stevenpyzhang/ksql that referenced this pull request Feb 4, 2021
@stevenpyzhang
fix: npe when getting topic configs (confluentinc#6946)
bf19b66
@stevenpyzhang stevenpyzhang mentioned this pull request Feb 4, 2021
Merged
2 tasks
stevenpyzhang added a commit that referenced this pull request Feb 4, 2021
@stevenpyzhang
fix: npe when getting topic configs (#6946) (#6949)
77d5215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcarlson5 wcarlson5 wcarlson5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE when getting command topic configs
2 participants
@stevenpyzhang @wcarlson5