feat: add functions as UDF input types #6955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
force-pushed
the
add-lambda-function-udf
branch
3 times, most recently
from
34c03c2
to
0afe244
Compare
stevenpyzhang
force-pushed
the
add-lambda-function-udf
branch
from
0afe244
to
6fc7df3
Compare
agavra
approved these changes
Feb 5, 2021
guozhangwang
approved these changes
Feb 5, 2021
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/map/MapReduce.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/map/MapReduce.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/map/MapTransform.java
Outdated
Show resolved
Hide resolved
rodesai
reviewed
Feb 9, 2021
| * Reduce a map using an initial state and function | ||
| */ | ||
| @UdfDescription( | ||
| name = "map_reduce", |
There was a problem hiding this comment.
can we name this reduce_map. Map Reduce has a different historical meaning that might make this confusing.
stevenpyzhang
force-pushed
the
add-lambda-function-udf
branch
from
78f5842
to
04c3e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functions as UDF argument types. Lambdas are still not usable though since we need to complete work in ExpressionTypeManager , CodeGenRunner, and SqlToJavaVisitor. (Coming soon)
Added in ARRAY_TRANSFORM, MAP_TRANSFORM, REDUCE_MAP
Testing done
Unit tests
Reviewer checklist