Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): add getInfo method to java client #7030

Merged
merged 3 commits into from
Feb 19, 2021
Merged

feat(client): add getInfo method to java client #7030

merged 3 commits into from
Feb 19, 2021

Conversation

jzaralim
Copy link
Contributor

Description

Add getInfo method to java client, which queries the /info endpoint

Testing done

unit test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner February 18, 2021 19:26
vcrfxia
vcrfxia reviewed Feb 18, 2021
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jzaralim -- looking great! Some minor comments inline.

ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/ServerInfo.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/ServerInfo.java Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/AdminResponseHandlers.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ClientImpl.java Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ServerInfoImpl.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ServerInfoImpl.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/ServerInfo.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/test/java/io/confluent/ksql/api/client/ClientTest.java Show resolved Hide resolved
@vcrfxia vcrfxia changed the title chore: add getInfo method to java client feat(client): add getInfo method to java client Feb 19, 2021
vcrfxia
vcrfxia approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jzaralim ! This is awesome :) Minor comments inline. Also I updated the PR title to reflect that is a new feature, available for general consumption 😁

ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/AdminResponseHandlers.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ServerInfoImpl.java Outdated Show resolved Hide resolved
ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ServerInfoImpl.java Outdated Show resolved Hide resolved
...api-client/src/test/java/io/confluent/ksql/api/client/integration/ClientIntegrationTest.java Outdated Show resolved Hide resolved
@jzaralim jzaralim merged commit b09f003 into confluentinc:master Feb 19, 2021
@jzaralim jzaralim deleted the info branch February 19, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaralim @vcrfxia