feat(migrations): implement clean command
#7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaralim
approved these changes
Mar 4, 2021
| private static boolean sourceExists(final String sourceName, final boolean isTable) { | ||
| final String sourceType = isTable ? "TABLE" : "STREAM"; | ||
| final List<KsqlEntity> entities = makeKsqlRequest("LIST " + sourceType + "S;"); | ||
| assertThat(entities, hasSize(1)); |
There was a problem hiding this comment.
I'm having trouble figuring out why this works - shouldn't the streams FOO and BAR also be listed here?
There was a problem hiding this comment.
There's only one entity returned from the ksql server. That one entity is a list of streams (or tables) which may contain multiple streams (or tables).
| @@ -73,7 +76,7 @@ private String createVersionTable(final String name, final String topic) { | |||
| + " latest_by_offset(completed_on) AS completed_on, \n" | |||
| + " latest_by_offset(previous) AS previous, \n" | |||
| + " latest_by_offset(error_reason) AS error_reason \n" | |||
| + " FROM migration_events \n" | |||
| + " FROM " + streamName + " \n" | |||
| + " GROUP BY version_key;\n"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
migrations cleancommand, which cleans up the migrations metadata stream and table (and underlying Kafka topics), if present.Also fixes a bug around custom migrations stream names.
Testing done
Unit + integration.
Reviewer checklist