Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add maven wrapper #7307

Merged
merged 1 commit into from
Mar 31, 2021
Merged

feat: add maven wrapper #7307

merged 1 commit into from
Mar 31, 2021

Conversation

xli1996
Copy link
Member

@xli1996 xli1996 commented Mar 26, 2021

Description

Disscusion around adopt maven wrapper to speed up building ksql. Ksql build can be slow using default maven due to https://issues.apache.org/jira/browse/MRESOLVER-164. A customized maven https://github.com/confluentinc/maven/tree/maven-3-6-3-patch with -DversionFilter parameter help reduce that issue.

Testing done

Replace mvn with ./mvnw

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

I am also consider if versionFilter should be default true, but probably need more testing.

@ghost
Copy link

ghost commented Mar 26, 2021

@confluentinc It looks like @xli1996 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@xli1996 xli1996 requested a review from a team March 26, 2021 18:49
@xli1996 xli1996 marked this pull request as ready for review March 30, 2021 16:21
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xli1996 . I think it makes sense to add this wrapper until MRESOLVER-164 is resolved. LGTM!

@guozhangwang guozhangwang merged commit d0ab425 into 6.1.x Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants