-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change the isError to not use the state #7483
Conversation
@confluentinc It looks like @wcarlson5 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wcarlson5 Could you update the description a bit for the rationales just for my education? Why we should not use the state for isError?
@guozhangwang since the state ERROR changed definitions the current isError is no longer really relevant. However it actually seems that isError is not used so I will just remove it |
+1 on putting what you just said in the PR description. Filling out the description just makes it easier to understand what the PR is about at a glance, which is useful eg if we ever have to skim over PRs looking for possible regressions. It's a good idea to always do, even if the changes in the PR are extremely obvious to you |
good call. TBH I was going to check with some more testing to see if I needed to remove it (which I can). I probably should have made it as a draft PR first. But thanks for the quick reviews! |
since the state ERROR changed definitions the current isError is no longer really relevant. However it actually seems that isError is not used so I will just remove it._
Reviewer checklist