test: add DATE/TIME to connect integration test #7732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Jun 28, 2021
Comment on lines
275
to
276
| final RestResponse<List<StreamedRow>> queryTime = ksqlRestClient.makeQueryRequest("SELECT CAST(PAYLOAD AS STRING) FROM TIME_STREAM EMIT CHANGES LIMIT 1;", 1L); | ||
| final RestResponse<List<StreamedRow>> queryDate = ksqlRestClient.makeQueryRequest("SELECT CAST(PAYLOAD AS STRING) FROM DATE_STREAM EMIT CHANGES LIMIT 1;", 1L); |
There was a problem hiding this comment.
Shouldn't we wait on this PR until the string implicit casting is done automatically? Like the timestamp example.
There was a problem hiding this comment.
This was due to the REST API not converting Date/Time objects to String correctly. I ended up just adding that fix to this PR though, since it is a small fix.
jzaralim
commented
Jun 28, 2021
| @@ -35,6 +35,12 @@ | |||
| <version>${io.confluent.ksql.version}</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>io.confluent.ksql</groupId> | |||
| <artifactId>ksqldb-engine-common</artifactId> | |||
There was a problem hiding this comment.
Needed because SqlTimeTypes is in this package. It's a very lightweight package and only has one dependency on ksqldb-common though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check that DATE/TIME work with connect by adding them to the connect integration test.
Reviewer checklist