feat: add DATEADD and DATESUB functions #7744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Jun 30, 2021
| "outputs": [ | ||
| {"topic": "TEST2", "key": 0, "value": {"VALUE": 0}}, | ||
| {"topic": "TEST2", "key": 0, "value": {"VALUE": 5}}, | ||
| {"topic": "TEST2", "key": 0, "value": {"VALUE": -3}} |
There was a problem hiding this comment.
I'm not sure if supporting this negative results. What does a DATE data type does when detecting a negative value?
There was a problem hiding this comment.
Connect translates dates before Epoch to negative numbers, so in this case its 1969-12-28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as the title says. this won't pass until #7733 is merged since that PR contains changes required to enable DATE for UDFs.
Testing done
QTT + unit tests.
Reviewer checklist