Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrap SchemaRegistry authorization errors into a KsqlSchemaAuthorizationException #7783

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

spena
Copy link
Member

@spena spena commented Jul 12, 2021

Description

What behavior do you want to change, why, how does your patch achieve the changes?
Part of #7773. This only added a new exception to manage SchemaRegistry authorization errors and calls it where it is needed.

#7773 requires other changes to provide better SR permissions checks.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena requested review from jzaralim and a team July 12, 2021 20:56
@spena spena merged commit 54eb419 into confluentinc:master Jul 13, 2021
@spena spena deleted the schema_auth_exception branch July 13, 2021 14:11
spena added a commit to spena/ksql that referenced this pull request Jul 15, 2021
spena added a commit to spena/ksql that referenced this pull request Jul 21, 2021
spena added a commit to spena/ksql that referenced this pull request Jul 22, 2021
spena added a commit to spena/ksql that referenced this pull request Jul 26, 2021
spena added a commit to spena/ksql that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants