Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase time out for migrations test #7784

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Jul 12, 2021

Description

There were some times when the shouldApplyMigrationsAndDisplayInfo was failing due to a materialized view not being available within 30s. I've seen this happen before on really slow Jenkins nodes, so we're just increasing the timeout and hoping it doesn't happen again. The integration test is worth keeping.

Testing done

Ran the test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from vcrfxia July 12, 2021 23:15
@agavra agavra requested a review from a team as a code owner July 12, 2021 23:15
Copy link
Member

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agavra !

It's worth trying this to see if it helps. We have also recently changed some default Client/Broker settings that might be making this stuff slower. Do you think we should try to introduce a blanket set of defaults to all integration tests to make them run more snappily?

(cc @guozhangwang )

@agavra
Copy link
Contributor Author

agavra commented Jul 13, 2021

Do you think we should try to introduce a blanket set of defaults to all integration tests to make them run more snappily?

@vvcephei I'm supportive of it - these are things like smaller buffering, faster commit intervals? Is there anything else we should consider?

@agavra agavra merged commit 1fd2ff1 into confluentinc:master Jul 13, 2021
@agavra agavra deleted the fix_migration_timeout branch July 13, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants