feat: add TO_BYTES/FROM_BYTES functions for bytes/string conversions #7831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
reviewed
Jul 20, 2021
JimGalasyn
reviewed
Jul 20, 2021
| ``` | ||
|
|
||
| Converts a STRING column in the specified encoding type to a BYTES column. | ||
| Supported encoding types are: 'hex', 'utf8', 'ascii', 'base64'. |
There was a problem hiding this comment.
Suggested change
| Supported encoding types are: 'hex', 'utf8', 'ascii', 'base64'. | |
| Supported encoding types are: `hex`, `utf8`, `ascii`, `base64`. |
JimGalasyn
reviewed
Jul 20, 2021
jzaralim
reviewed
Jul 20, 2021
| @@ -35,7 +35,6 @@ | |||
| * with your change. Otherwise, {@link PlannedTestsUpToDateTest} fill fail if there are missing | |||
| * or changed query plans. | |||
| */ | |||
| @Ignore("Comment me out to regenerate the historic plans") | |||
| @Udf(description = "Converts a BYTES value to STRING in the specified encoding. " | ||
| + "The accepted encoders are 'hex', 'utf8', 'ascii', and 'base64'.") | ||
| public String fromBytes(final ByteBuffer value, final String encoding) { | ||
| return (value == null) ? null : BytesUtils.encode(value.array(), encoding); |
There was a problem hiding this comment.
The Protobuf deserializer deserializes to a read-only byte buffer, so value.array() might throw.
| import static org.hamcrest.Matchers.nullValue; | ||
| import static org.junit.Assert.assertThrows; | ||
|
|
||
| public class FromBytesTest { |
There was a problem hiding this comment.
Can we also have a test for an empty byte array?
|
|
||
| import java.nio.ByteBuffer; | ||
|
|
||
| public class ToBytesTest { |
There was a problem hiding this comment.
Can we also have a test for an empty string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
TO_BYTESandFROM_BYTESfunctions. Supported encodings arehex,ascii,utf8, andbase64.Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist