Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update len function to accept BYTES #7865

Merged
merged 1 commit into from
Jul 26, 2021
Merged

feat: update len function to accept BYTES #7865

merged 1 commit into from
Jul 26, 2021

Conversation

jzaralim
Copy link
Contributor

Description

update LEN function to accept either STRING or BYTES

Testing done

QTT and unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from spena July 23, 2021 03:31
@jzaralim jzaralim requested review from JimGalasyn and a team as code owners July 23, 2021 03:31
JimGalasyn
JimGalasyn approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

spena
spena approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena merged commit eaaa0db into confluentinc:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzaralim @spena @JimGalasyn