Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated minor syntax updates in docs #7949

Merged

Conversation

tolgadur
Copy link
Contributor

@tolgadur tolgadur commented Aug 4, 2021

Description

I noticed that this page in the docs is missing some syntax that is included in the newer versions of ksql. This is PR is updating that.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@tolgadur tolgadur requested review from JimGalasyn and a team as code owners August 4, 2021 19:41
@ghost
Copy link

ghost commented Aug 4, 2021

@confluentinc It looks like @tolgadur just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@colinhicks colinhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes!

@vcrfxia vcrfxia changed the title feat: updated minor syntax updates in docs docs: updated minor syntax updates in docs Aug 4, 2021
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tolgadur ! I updated the PR title to be "docs" instead of "feat" so this PR won't appear in the changelog for the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants