Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds a new config check to insert SPQ Processor #8062

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

AlanConfluent
Copy link
Member

@AlanConfluent AlanConfluent commented Aug 26, 2021

Description

Replaces the check for ksql.query.push.scalable.enabled with ksql.query.push.scalable.registry.installed to insert the streams Processor for Scalable Push Queries. The idea behind this is that we want the user to be able to enable SPQs using the config ksql.query.push.scalable.enabled per request or in the CLI and control the registry installation separately.

Also, ups the ProcessingQueue limit to 1000 to allow for larger bursts.

Testing done

Verified it works as intended.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@AlanConfluent AlanConfluent requested a review from a team as a code owner August 26, 2021 18:47
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to the idea of making this enabling at the per-query/request level.

Just clarifying, at the per-request level this config is still turned off by default or not?

Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! as discussed offline, I'm +1

@AlanConfluent
Copy link
Member Author

I'm +1 to the idea of making this enabling at the per-query/request level.

Just clarifying, at the per-request level this config is still turned off by default or not?

It is off by default, but will be possible to enable per query, in which case it will still only use SPQs if they are appropriate.

@AlanConfluent AlanConfluent merged commit a0be1d5 into confluentinc:master Sep 1, 2021
@AlanConfluent AlanConfluent changed the title fix: Removes config check to insert SPQ Processor fix: Adds a new config check to insert SPQ Processor Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants