-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shared runtime config to QueryPlan #8074
feat: add shared runtime config to QueryPlan #8074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Could we add a test covering the case e.g. even with the global config set to true, if a specific query has it false, or does not set it (since it's written from an older version) in the query plan, that specific query would not be assigned to the shared runtime still.
@guozhangwang good idea. I added a test that should verify that global config is only used when creating the query plan. I also made it so that for any query plans that get serialized with out it set will default to false. Eventually when we remove the FF we will remove it from the query plan as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for converting the field to a string as well. I do not have further comments. cc @rodesai .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but @rodesai should probably give it a quick final pass since I'm still just a ksql noob 🙂
Make it so the config value for shared runtimes are enabled is written into the cmd topic so it is specific to when each query was launched
Reviewer checklist