fix: Always dec. concurrency counter, even hitting rate limits #8165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanConfluent
force-pushed
the
fix_bandwidth_limit
branch
from
0a561ef
to
704b30b
Compare
cprasad1
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
LGTM @AlanConfluent. Thanks for the fix! Couple of minor comments
| @@ -316,7 +316,7 @@ private EndpointResponse handleStatement( | |||
| } | |||
| } catch (final TopicAuthorizationException e) { | |||
| return errorHandler.accessDeniedFromKafkaResponse(e); | |||
| } catch (final KsqlStatementException e) { | |||
| } catch (final KsqlStatementException e) {; | |||
| @@ -93,6 +96,7 @@ protected synchronized void allow(final KsqlQueryType ksqlQueryType, final long | |||
| this.numBytesInWindow -= responseSizesLog.poll().right; | |||
| } | |||
| if (this.numBytesInWindow > throttleLimit) { | |||
| LOG.warn("Hit bandwidth rate limit of " + throttleLimit + " with use of " + numBytesInWindow); | |||
There was a problem hiding this comment.
We should add the unit MB in the warning message here to be more explicit
|
@AlanConfluent Do we foresee the concurrency counter not getting decremented when we hit other types of exceptions in pull query execution? |
vvcephei
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Thanks @AlanConfluent ! This is a great catch.
I just had one question.
| } catch (final Throwable t) { | ||
| LOG.error("Error closing pull query queue", t); | ||
| } | ||
| future.complete(null); |
There was a problem hiding this comment.
It shouldn't be completed exceptionally if we fail to close?
AlanConfluent
force-pushed
the
fix_bandwidth_limit
branch
from
61492ce
to
0dd01b6
Compare
cprasad1
pushed a commit
that referenced
this pull request
Oct 4, 2021
* fix: Always dec. concurrency counter, even hitting rate limits
cprasad1
pushed a commit
to cprasad1/ksql
that referenced
this pull request
Oct 4, 2021
…uentinc#8165) * fix: Always dec. concurrency counter, even hitting rate limits
wcarlson5
pushed a commit
that referenced
this pull request
Oct 5, 2021
#8223) * fix: Always dec. concurrency counter, even hitting rate limits (#8165) * fix: Always dec. concurrency counter, even hitting rate limits * chore: fix pull query compilation Co-authored-by: Alan Sheinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the bandwidth rate limit is hit, it never decrements the concurrency counter. This change ensures it always does.
Testing done
Ran tests and verified manually
Reviewer checklist