Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metrics for stream pull queries to WS #8174

Merged
merged 7 commits into from
Sep 29, 2021
Merged

feat: Add metrics for stream pull queries to WS #8174

merged 7 commits into from
Sep 29, 2021

Conversation

vpapavas
Copy link
Member

Description

Add metrics for stream pull queries to WS. We don't record request/response bytes and status code.

Testing done

Junit test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vpapavas vpapavas requested a review from a team as a code owner September 24, 2021 20:13
nateab
nateab approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@nateab nateab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vvcephei
vvcephei approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vpapavas !

Nice work figuring out how to add that metrics callback.

@vpapavas vpapavas merged commit d75f254 into confluentinc:master Sep 29, 2021
@agavra agavra mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvcephei vvcephei vvcephei approved these changes

@nateab nateab nateab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpapavas @vvcephei @nateab