Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly capture rows returned for scalable push query metrics #8230

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

nateab
Copy link
Member

@nateab nateab commented Oct 5, 2021

Description

What behavior do you want to change, why, how does your patch achieve the changes?
Correctly capture rows returned for scalable push query metrics, by using a TransientQueryQueue in the scalable push query metadata, since that is the queue we pass in anyway during instantiation.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Unit tests updated

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@nateab nateab requested a review from a team as a code owner October 5, 2021 18:27
@nateab nateab merged commit da4f71e into confluentinc:master Oct 5, 2021
@nateab nateab deleted the spq_metrics_rows branch October 5, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants