Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: retry shouldListTopics test #8244

Merged
merged 1 commit into from
Oct 12, 2021
Merged

test: retry shouldListTopics test #8244

merged 1 commit into from
Oct 12, 2021

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Oct 8, 2021

Description

The test fails if the connect instance isn't up by the time the test is run. This will make the test retry for 30 seconds.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner October 8, 2021 21:04
@jzaralim jzaralim requested a review from lct45 October 8, 2021 21:05
lct45
lct45 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@lct45 lct45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix @jzaralim

@jzaralim jzaralim merged commit 7c7ac07 into master Oct 12, 2021
@jzaralim jzaralim deleted the eventually branch October 12, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lct45 lct45 lct45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaralim @lct45